[PATCH] D90050: AMDGPU/GlobalISel: Add integer med3 combines

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 08:44:17 PST 2020


Petar.Avramovic added a comment.

Should we move this combine after register bank select and skip min/max with sgpr bank?



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:281
+
+template <class m_Cst>
+bool AMDGPUPostLegalizerCombinerHelper::matchMed(MachineInstr &MI,
----------------
foad wrote:
> Is this a template so that you can use it for floating point values in the future? Then shouldn't "CstRegMatch" be called "ICstRegMatch"?
Yes, fmed3 will match fconstant, and clamp fconstant or splat value


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90050/new/

https://reviews.llvm.org/D90050



More information about the llvm-commits mailing list