[PATCH] D91724: [HardwareLoops] Change order of SCEV expression construction for InitLoopCount.
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 07:01:46 PST 2020
samparker added inline comments.
================
Comment at: llvm/lib/CodeGen/HardwareLoops.cpp:388
+ ExitCount = SE.getAddExpr(ExitCount, SE.getOne(ExitCount->getType()));
if (!ExitCount->getType()->isPointerTy() &&
ExitCount->getType() != CountType)
----------------
Could you also double check that this PointerTy check is necessary, it seems a little odd to me but I don't know much about the PPC implementation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91724/new/
https://reviews.llvm.org/D91724
More information about the llvm-commits
mailing list