[PATCH] D90610: [Inline] Fix in handling of ptrtoint in InlineCost

Thu Nov 19 06:42:41 PST 2020

uabelho added a comment.

In D90610#2376116 <https://reviews.llvm.org/D90610#2376116>, @mtrofin wrote:

> In D90610#2370539 <https://reviews.llvm.org/D90610#2370539>, @uabelho wrote:
>
>> In D90610#2368489 <https://reviews.llvm.org/D90610#2368489>, @mtrofin wrote:
>>
>>> Thanks for looking into this!
>>>
>>> Should places where we use ConstantOffsetPtrs to determine if instructions may be simplified, like CallAnalyzer::visitCmpInst, be also adjusted? Or does the ContantExpr::getICmp call take care of different-sized constant ints?
>>
>> I don't know. When I debugged PR49890 I just realized that the size mismatch was introduced with the ptrtoint, so I tried doing something about that instead of trying to handle it at every use of ConstantOffsetPtrs. And then I realized that fix seems to have fixed PR38500 as well.
>
> I think it would be good to understand that, as part of this patch, as changing that  may have performance implications.

Maybe it is. I don't have time to really dig into that, so if that is a prerequisite to landing the fix then someone else is free to take over this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90610/new/

https://reviews.llvm.org/D90610