[PATCH] D91773: [AArch64] Add SubtargetFeatures for v8.7-A options

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:406
+
+def FeatureHCX : SubtargetFeature<
+    "hcx", "HasHCX", "true", "Enable Armv8.7-A HCRX_EL2 system register">;
----------------
simon_tatham wrote:
> ostannard wrote:
> > Why is this `FeatureHCX`, and not `FeatureHCRX` for consistency with the register name?
> "HCX" is the name of the field in ID_AA64MMFR_1 that indicates the presence of that register.
Ok, that's fine then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91773/new/

https://reviews.llvm.org/D91773