[PATCH] D91701: [AMDGPU] Implement flat scratch init for pal

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:320
+  MBB.addLiveIn(GitPtrLo);
+  BuildMI(MBB, I, DL, SMovB32, TargetLo).addReg(GitPtrLo);
+}
----------------
rampitec wrote:
> rampitec wrote:
> > .addReg() on the next line.
> Isn't this a first subreg def, so this one shall have superreg def?
> .addReg() on the next line.

The autoformatter complained about that, shall I do it anyway?

> Isn't this a first subreg def, so this one shall have superreg def?

I’m not sure? In the if-branch, `TargetHi` is defined, in the else-branch the whole `TargetReg` is defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91701/new/

https://reviews.llvm.org/D91701