[PATCH] D91767: [DomTree][NFC] Introduce function that finds common dom of multiple instructions
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 19 04:18:20 PST 2020
mkazantsev added inline comments.
================
Comment at: llvm/lib/IR/Dominators.cpp:348
+ Instruction *CommonDom = *It++;
+ for (auto E = Insns.end(); It != E; ++It) {
+ Instruction *Curr = *It;
----------------
skatkov wrote:
> What if you meet PHi node?
Added comment explaining how we handle phis, added respective tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91767/new/
https://reviews.llvm.org/D91767
More information about the llvm-commits
mailing list