[PATCH] D86975: [IRSim][IROutliner] Adding the extraction basics for the IROutliner.

Yvan Roux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 02:19:12 PST 2020


yroux added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:852
 
+  if (EnableIROutliner)
+    MPM.add(createIROutlinerPass());
----------------
jroelofs wrote:
> Out of curiosity, how did you decide that this was the optimal spot in the pass stack for it?
Looking at what was presented by River Riddle back in 2017 and the former proposal of an IR Outlining pass in 2018, there was the notion of early (pre inlining) and late (pre Isel) outlining and the combination of both had better results in what was presented, is it something we can do here ?

I also think that it can be added to late LTO passes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86975/new/

https://reviews.llvm.org/D86975



More information about the llvm-commits mailing list