[PATCH] D91632: [TableGen] [ISel Matcher Emitter] Rework with two passes: one to size, one to emit

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/utils/TableGen/DAGISelMatcher.h:92
+    // Highest enum value; watch out when adding more.
+    HighestKind = MorphNodeTo
   };
----------------
We seem to mainly use this as "HighestKind + 1" - wouldn't a NumOfKinds / KindCount value be better (and wouldn't need the assignment to the previous enum value).
```
  MorphNodeTo, // Build a node, finish a match and update results.
  KindCount        // Total number of kind types.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91632/new/

https://reviews.llvm.org/D91632