[PATCH] D91732: [compiler-rt] [builtins] Support conversion between fp16 and fp128

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 01:43:21 PST 2020


ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.

LGTM

> Also, __fp16 is a storage format and promoted to 'float' for argument passing

It doesn't affect this patch, but for all of the ARM and AArch64 ABIs, __fp16 arguments are passed in the bottom half of an integer or FP register, not promoted to float. There was an old version of the AArch32 ABI (I think) which did that, but I don't think any compiler implemented it before it was changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91732/new/

https://reviews.llvm.org/D91732



More information about the llvm-commits mailing list