[PATCH] D90930: [lib/Support/YAMLTraits] - Don't print leading zeroes when dumping Hex8/Hex16/Hex32 types.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 19 00:26:25 PST 2020


grimar added a comment.

In D90930#2402925 <https://reviews.llvm.org/D90930#2402925>, @goncharov wrote:

> @grimar this one slipped through https://github.com/llvm/llvm-project/commit/8c1e3cbebfe9ff14829a279b9d229d4fc3f190b1

Oh, sorry about that. This because it the test has "REQUIRES : system-darwin" I think. It just doesn't run on my windows/linux systems.

> unrelated, but I wonder how your diff https://reviews.llvm.org/D90930?id=303810 ended up without repository assigned? (e.g. builds didn't run)

When I create a new diff, I fill "Title", "Summary", "Reviewers" and "Subscribers". I never tried to fill "Repository" field by myself. Honestly I've just
realized that this is the reason why Harbormaster doesn't build diffs from all my reviews. I just didn't know how this feature exactly works.
Will try next time :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90930/new/

https://reviews.llvm.org/D90930



More information about the llvm-commits mailing list