[PATCH] D91753: [GlobalISel] Add an isExtendedTrueVal helper.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:746
+  if (ExtTy == S1)
+    return Val == 1;
+  switch (TLI.getBooleanContents(ExtTy.isVector(), IsFP)) {
----------------
Not saying this is wrong, but what's the rationale here for Val needing to be exactly 1 for s1? If The type is s1 then isn't either -1 or 1 equivalently true?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91753/new/

https://reviews.llvm.org/D91753