[PATCH] D91583: [lld] Allow --export-dynamic to override --lto-whole-program-visibility

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D91583#2404519 <https://reviews.llvm.org/D91583#2404519>, @pcc wrote:

> I've said before that I think that `--lto-whole-program-visibility` should relax visibility of vtable symbols etc to hidden. That way, `--export-dynamic` wouldn't actually allow you to make this kind of mistake.

That would presumably result in an error in some of the problematic cases, whereas here we want to simply suppress --lto-whole-program-visibility to avoid any issues automatically.

But isn't it the case that you don't even need for the vtable symbol itself to be exported in order to derive from the class and override its virtual methods?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91583/new/

https://reviews.llvm.org/D91583