[PATCH] D61767: [llvm-elfabi] Emit ELF header and string table section

[Haowei Wu via Phabricator via llvm-commits]

haowei added inline comments.


================
Comment at: llvm/tools/llvm-elfabi/llvm-elfabi.cpp:125
 
+void fatalError(Error Err) {
+  WithColor::defaultErrorHandler(std::move(Err));
----------------
MaskRay wrote:
> Use static for these functions
> 
> https://llvm.org/docs/CodingStandards.html#anonymous-namespaces
> 
> The coding standard also says non-exported class declarations should be written in anonymous namespaces
I added static.

This is not a class declaration I guess I don't need to put it into anonymous namespace.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61767/new/

https://reviews.llvm.org/D61767