[PATCH] D91467: ADT: Take small enough, trivially copyable T by value in SmallVector

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added 1 blocking reviewer(s): njames93.
dexonsmith added a comment.

In D91467#2404392 <https://reviews.llvm.org/D91467#2404392>, @mehdi_amini wrote:

> Oh I didn't read about https://reviews.llvm.org/D87326 before, isn't the work there making obsolete all of the assertions you (and me before) just added by making this behavior safe?

Yes, but that revision is blocked on landing due to compile-time regressions. It needs some number of commits to land first; maybe this is one of them; and I couldn't figure out how to test this one reasonably without adding the assertions; and it seems reasonable to fix existing bugs (with the assertions) while we wait for the beautiful future in case it doesn't come tomorrow.

Making @njames93 a blocking reviewer since I think we shouldn't move forward unless there appears to be a path to fixing invalidation generally (this seems like a useful incremental step, but I agree with @mehdi_amini that if things stop here the mental model is confusing for little gain).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91467/new/

https://reviews.llvm.org/D91467