[PATCH] D91744: ADT: Add assertions to SmallVector::insert, etc., for reference invalidation

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith updated this revision to Diff 306267.
dexonsmith marked an inline comment as done.
dexonsmith added a comment.
Herald added subscribers: kerbowa, hiraditya, nhaehnle, jvesely, arsenm.

Running check-all for llvm/clang/clang-tools-extra hit three more assertions, now fixed (since splitting the patch out from https://reviews.llvm.org/D91467 I'd just run `ADTTests` until now):

- Two `MCInst::insert` calls.
- One `emplace_back` call with an internal reference.

I'll commit in a minute.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91744/new/

https://reviews.llvm.org/D91744

Files:
  llvm/include/llvm/ADT/SmallVector.h
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
  llvm/unittests/ADT/SmallVectorTest.cpp
  llvm/utils/TableGen/CodeGenSchedule.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91744.306267.patch
Type: text/x-patch
Size: 16034 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201119/4e7fe019/attachment.bin>