[PATCH] D61767: [llvm-elfabi] Emit ELF header and string table section

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-elfabi/llvm-elfabi.cpp:125
 
+void fatalError(Error Err) {
+  WithColor::defaultErrorHandler(std::move(Err));
----------------
Use static for these functions

https://llvm.org/docs/CodingStandards.html#anonymous-namespaces

The coding standard also says non-exported class declarations should be written in anonymous namespaces


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61767/new/

https://reviews.llvm.org/D61767