[PATCH] D91744: ADT: Add assertions to SmallVector::insert, etc., for reference invalidation

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/ADT/SmallVector.h:735
+                       T>::value,
+          bool> = true>
+  reference emplace_back(ArgType &&Arg) {
----------------
Do you need the SFINAE and the two implementation?
Wouldn't it always be valid to call `    this->assertSafeToAdd(&Arg);`? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91744/new/

https://reviews.llvm.org/D91744