[PATCH] D91648: [DebugInfo] Dexter tests for -debug-info-kind=constructor

[Jeremy Morse via Phabricator via llvm-commits]

jmorse updated this revision to Diff 306198.
jmorse added a comment.

> I tried running this patch on my machine though and the tests always pass (using llvm-lit) even if I change numbers, so I don't know if something's going on with the directory test format?

Hmmmmmm, I tried to apply the patch locally too, and "patch" seemingly omitted the empty test.cfg files. I've given them a non-empty body now, so perhaps they'll survive better.

Other tweaks:

- Duplicated test-runner files, one for unix one for Windows and cdb/dbgeng. (Using the same RUN lines is still a work-in-progress with Dexter, alas)
- dllexport'd the main symbol, as dbgeng has a problem setting a breakpoint there for some reason
- Disabled the LTO test on Windows -- using WinDbg I can't find any locals in the compiled code (saved with --save-temps). Not clear to me why -- CodeView is alien to me.
- DbgEng test runs relies on D91737 <https://reviews.llvm.org/D91737> for a fix

Will land this without objection in a couple of days, once D91737 <https://reviews.llvm.org/D91737> is in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91648/new/

https://reviews.llvm.org/D91648

Files:
  debuginfo-tests/dexter-tests/debug-info-kind-cons/lit.local.cfg
  debuginfo-tests/dexter-tests/debug-info-kind-cons/partial-type/construct.cpp
  debuginfo-tests/dexter-tests/debug-info-kind-cons/partial-type/main.cpp
  debuginfo-tests/dexter-tests/debug-info-kind-cons/partial-type/test.cfg
  debuginfo-tests/dexter-tests/debug-info-kind-cons/partial-type/theclass.h
  debuginfo-tests/dexter-tests/debug-info-kind-cons/partial-type/unix.dexter
  debuginfo-tests/dexter-tests/debug-info-kind-cons/partial-type/win.dexter
  debuginfo-tests/dexter-tests/debug-info-kind-cons/simple/construct.cpp
  debuginfo-tests/dexter-tests/debug-info-kind-cons/simple/main.cpp
  debuginfo-tests/dexter-tests/debug-info-kind-cons/simple/test.cfg
  debuginfo-tests/dexter-tests/debug-info-kind-cons/simple/theclass.h
  debuginfo-tests/dexter-tests/debug-info-kind-cons/simple/unix.dexter
  debuginfo-tests/dexter-tests/debug-info-kind-cons/simple/win.dexter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91648.306198.patch
Type: text/x-patch
Size: 8344 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201118/3617b138/attachment.bin>