[PATCH] D90507: Adding DWARF64 clang flag

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4018
 
+  if (Args.hasArg(options::OPT_gdwarf64)) {
+    const Arg *A = Args.getLastArg(options::OPT_gdwarf64);
----------------
`if (const Arg *A = Args.getLastArg(options::OPT_gdwarf64)`)


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4020
+    const Arg *A = Args.getLastArg(options::OPT_gdwarf64);
+    const llvm::Triple &RawTriple = TC.getTriple();
+    if (DWARFVersion < 3)
----------------
The variable is only used once. Inline it


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90507/new/

https://reviews.llvm.org/D90507