[PATCH] D91575: [GWP-ASan] Port tests to Fuchsia

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 13:42:20 PST 2020


phosek added inline comments.


================
Comment at: compiler-rt/lib/gwp_asan/tests/harness.h:15
+#if defined(__Fuchsia__)
+#include <zxtest/zxtest.h>
+using Test = ::zxtest::Test;
----------------
Not an immediate concern, but when we start running compiler-rt tests on Fuchsia, this may become an issue because we don't ship zxtest in our SDK. We might need to come up with a different solution then, for example have a dedicated `define` to control which test framework is being used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91575/new/

https://reviews.llvm.org/D91575



More information about the llvm-commits mailing list