[PATCH] D91734: [FastISel] Flush local value map on every instruction

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:209
+      bool UsedByPHI = isRegUsedByPhiNodes(DefReg, FuncInfo);
+      if (!UsedByPHI && MRI.use_nodbg_empty(DefReg)) {
+        if (EmitStartPt == &LocalMI)
----------------
rnk wrote:
> This dead local value removal logic was part of D43093, right? At least, that's what I remember. Anyway, it's pretty simple, so I agree we should keep it.
Yes, this is modeled on that code.  It definitely catches things.

I was trying to use removeDeadLocalValueCode but it caught too much, so I went back to this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91734/new/

https://reviews.llvm.org/D91734