[PATCH] D91734: [FastISel] Flush local value map on every instruction

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: MatzeB.
rnk added a comment.

Thanks! It looks like the presubmit/Harbormaster testing found some more test failures that need addressing.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/FastISel.cpp:209
+      bool UsedByPHI = isRegUsedByPhiNodes(DefReg, FuncInfo);
+      if (!UsedByPHI && MRI.use_nodbg_empty(DefReg)) {
+        if (EmitStartPt == &LocalMI)
----------------
This dead local value removal logic was part of D43093, right? At least, that's what I remember. Anyway, it's pretty simple, so I agree we should keep it.


================
Comment at: llvm/test/CodeGen/Mips/emergency-spill-slot-near-fp.ll:5-6
 
+; After recent rework to FastISel, don't know how to trigger the emergency
+; spill slot.
+; XFAIL: *
----------------
Huh. @MatzeB, do you think this test case can be repaired?


================
Comment at: llvm/test/DebugInfo/X86/fission-ranges.ll:44-45
 
 ; Don't assume these locations are entirely correct - feel free to update them
 ; if they've changed due to a bugfix, change in register allocation, etc.
 
----------------
Well there's a fragile test. :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91734/new/

https://reviews.llvm.org/D91734