[PATCH] D90249: Add options to enable memoryssa for loopsink, expand loopsink testing and fix exposed bug in LICM

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 12:53:44 PST 2020


nikic added a comment.

Looking over the patch, the compile-time regression is likely not related to MemorySSA, but the fact that you moved the AST construction before the `!Preheader->getParent()->hasProfileData()` check, and the profitability heuristic. This means that expensive AST construction now happens every time, instead of only when useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90249/new/

https://reviews.llvm.org/D90249



More information about the llvm-commits mailing list