[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 12:36:10 PST 2020


ZarkoCA added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235
+    return TM.isPPC64()
+               ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask
+                                         : CSR_PPC64_RegMask)
----------------
sfertile wrote:
> `CSR_64_AllRegs_Altivec_RegMask` should be `CSR_PPC64_Altivec_RegMask`.  FWIW I don't think this is testable without D86476. If that's the case, then it should go in that patch, not this patch. 
Are you suggesting that I also leave the error in if I were to move this change to D84676? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88676/new/

https://reviews.llvm.org/D88676



More information about the llvm-commits mailing list