[PATCH] D91677: Avoid simplification of library functions when callee has an implementation

[Siddhesh Poyarekar via Phabricator via llvm-commits]

siddhesh added a comment.

In D91677#2403232 <https://reviews.llvm.org/D91677#2403232>, @lebedev.ri wrote:

> And by mark them, you could also use `-fno-builtin=???`, see D68028 <https://reviews.llvm.org/D68028>.

That would imply having to always add `-fno-builtin` along with `-D_FORTIFY_SOURCE`, which seems even worse than adding `__attribute__((no_builtin))` to fortified bcopy implementations in libc since it would have to be done for all sources when building with llvm just so that it does not optimize away fortifications.

Could you elaborate on why you would like to keep the option to simplify calls to library functions with implementations by default and not the other way around as this patch proposes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91677/new/

https://reviews.llvm.org/D91677