[PATCH] D88741: [SystemZ/z/OS] Add utility class for char set conversion.
Fanbo Meng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 10:01:40 PST 2020
fanbo-meng added inline comments.
================
Comment at: llvm/lib/Support/CharSet.cpp:89
+
+enum { NoUTF = 0x0, SrcIsUTF = 0x1, DstIsUTF = 0x2 };
+
----------------
The naming here with "UTF" is ambiguous as it can mean UTF8, UTF16, UTF32. Using UTF8 with the enum names here would be better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88741/new/
https://reviews.llvm.org/D88741
More information about the llvm-commits
mailing list