[PATCH] D91275: [FileCheck] Disallow unused prefixes in llvm/test/Analysis

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/lit.cfg.py:87
+# expanding FileCheck to the full path.
+config.substitutions.append(('%FileCheckWithUnusedPrefixes%', 
+    'FileCheck --allow-unused-prefixes=true'))
----------------
mtrofin wrote:
> MaskRay wrote:
> > Does `('FileCheck', 'FileCheck --allow-unused-prefixes=true')` work?
> > 
> > You may take a look at some tools like opt,llc,llvm-mc,etc. They expand to the absolute paths. It is possible that FileCheck can use the same trick, but expand with another argument, so that you don't have to update the tests.
> The intent is to have a way to set --allow-unused-prefixes=false under whole directories, and offer a "way out" for the files where we want to allow it. This way, we can "seal" to the desired behavior whole directories after they are fixed.
> 
> This patch does that for llvm/test/Analysis.
> 
> We still don't want to blanket-allow the undesirable behavior for entire directories.
Do we still need this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91275/new/

https://reviews.llvm.org/D91275