[llvm] 480ad4a - HazardRecognizer - Fix definition/declaration argument name mismatches. NFCI.
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 08:51:16 PST 2020
Author: Simon Pilgrim
Date: 2020-11-18T16:50:52Z
New Revision: 480ad4afc215de922ef6aa2ea3befa8d563d00bd
URL: https://github.com/llvm/llvm-project/commit/480ad4afc215de922ef6aa2ea3befa8d563d00bd
DIFF: https://github.com/llvm/llvm-project/commit/480ad4afc215de922ef6aa2ea3befa8d563d00bd.diff
LOG: HazardRecognizer - Fix definition/declaration argument name mismatches. NFCI.
Consistently use SUnit *SU (or drop the argname entirely if not used like the other HazardRecognizer methods).
Silences cppcheck warnings.
Added:
Modified:
llvm/include/llvm/CodeGen/MultiHazardRecognizer.h
llvm/include/llvm/CodeGen/ScheduleHazardRecognizer.h
llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
llvm/lib/Target/SystemZ/SystemZHazardRecognizer.h
Removed:
################################################################################
diff --git a/llvm/include/llvm/CodeGen/MultiHazardRecognizer.h b/llvm/include/llvm/CodeGen/MultiHazardRecognizer.h
index be35be5680c2..9846045ff014 100644
--- a/llvm/include/llvm/CodeGen/MultiHazardRecognizer.h
+++ b/llvm/include/llvm/CodeGen/MultiHazardRecognizer.h
@@ -30,7 +30,7 @@ class MultiHazardRecognizer : public ScheduleHazardRecognizer {
void AddHazardRecognizer(std::unique_ptr<ScheduleHazardRecognizer> &&);
bool atIssueLimit() const override;
- HazardType getHazardType(SUnit *m, int Stalls = 0) override;
+ HazardType getHazardType(SUnit *, int Stalls = 0) override;
void Reset() override;
void EmitInstruction(SUnit *) override;
void EmitInstruction(MachineInstr *) override;
diff --git a/llvm/include/llvm/CodeGen/ScheduleHazardRecognizer.h b/llvm/include/llvm/CodeGen/ScheduleHazardRecognizer.h
index 53c5fc0edee5..9f1101b658d0 100644
--- a/llvm/include/llvm/CodeGen/ScheduleHazardRecognizer.h
+++ b/llvm/include/llvm/CodeGen/ScheduleHazardRecognizer.h
@@ -57,7 +57,7 @@ class ScheduleHazardRecognizer {
/// other instruction is available, issue it first.
/// * NoopHazard: issuing this instruction would break the program. If
/// some other instruction can be issued, do so, otherwise issue a noop.
- virtual HazardType getHazardType(SUnit *m, int Stalls = 0) {
+ virtual HazardType getHazardType(SUnit *, int Stalls = 0) {
return NoHazard;
}
diff --git a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
index e2af02227999..35bd16d8def1 100644
--- a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
+++ b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.cpp
@@ -74,8 +74,8 @@ unsigned SystemZHazardRecognizer::getCurrCycleIdx(SUnit *SU) const {
}
ScheduleHazardRecognizer::HazardType SystemZHazardRecognizer::
-getHazardType(SUnit *m, int Stalls) {
- return (fitsIntoCurrentGroup(m) ? NoHazard : Hazard);
+getHazardType(SUnit *SU, int Stalls) {
+ return (fitsIntoCurrentGroup(SU) ? NoHazard : Hazard);
}
void SystemZHazardRecognizer::Reset() {
diff --git a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.h b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.h
index 38bf41ebe96a..b2ee64a1bb4a 100644
--- a/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.h
+++ b/llvm/lib/Target/SystemZ/SystemZHazardRecognizer.h
@@ -113,7 +113,7 @@ class SystemZHazardRecognizer : public ScheduleHazardRecognizer {
Reset();
}
- HazardType getHazardType(SUnit *m, int Stalls = 0) override;
+ HazardType getHazardType(SUnit *SU, int Stalls = 0) override;
void Reset() override;
void EmitInstruction(SUnit *SU) override;
More information about the llvm-commits
mailing list