[PATCH] D91461: [build] normalize components dependencies

Wed Nov 18 08:28:54 PST 2020

mgorny added a comment.

In D91461#2402833 <https://reviews.llvm.org/D91461#2402833>, @serge-sans-paille wrote:

> In D91461#2402720 <https://reviews.llvm.org/D91461#2402720>, @mgorny wrote:
>
>> Or to put it the other way, `LINK_COMPONENTS` is not equivalent to `target_link_libraries` with the `PUBLIC` keyword.
>
> Do you think we should revert the whole patch, or only a subpart of it?

That once instance should be sufficient. If you could put a comment emphasizing that `PUBLIC` is used to propagate dependencies and therefore it's not the same as `LINK_COMPONENTS`, that would be great too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91461/new/

https://reviews.llvm.org/D91461