[PATCH] D91532: [NFC][CostModel]Extend class IntrinsicCostAttributes to use ElementCount Type
Caroline via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 18 07:52:04 PST 2020
CarolineConcatto added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:1153
+ ElementCount RetVF =
+ (RetTy->isVectorTy() ? cast<FixedVectorType>(RetTy)->getElementCount()
+ : ElementCount::getFixed(1));
----------------
sdesmalen wrote:
> This can now check for VectorType.
This change means that we can now accept scalable vectors, meaning that we will have a functional change. That is not the goal of this patch. I am working on another patch after this that will make the functional change to accept scalable vectors.
I believe it is fine to leave this patch as it is and create another patch that will be able to accept the scalable vector and then add a regression test to validate the change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91532/new/
https://reviews.llvm.org/D91532
More information about the llvm-commits
mailing list