[PATCH] D91701: [AMDGPU] Implement flat scratch init for pal

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:322
+      .addReg(GitPtrLo)
+      .addReg(TargetReg, RegState::ImplicitDefine);
+}
----------------
You should only need the implicit def of the super reg on the first subreg def


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:393
+        .addImm(0)             // dlc
+        .addReg(FlatScrInit, RegState::ImplicitDefine)
+        .addMemOperand(MMO);
----------------
This already has the explicit def, so I don't see why this implicit def is added


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91701/new/

https://reviews.llvm.org/D91701