[PATCH] D91250: Support intrinsic overloading on unnamed types

Jeroen Dobbelaere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 06:55:39 PST 2020


jeroen.dobbelaere added a comment.

In D91250#2402087 <https://reviews.llvm.org/D91250#2402087>, @fhahn wrote:

> I think we would also need tests for combining multiple modules with intrinsics with unnamed type.
>
> If the module owns the numbering,  can encounter name/type clashes, e.g. if 2 modules have unnamed types that are different. i.e. both have `declare %0* @llvm.ssa.copy.p0s_s.0(%0* returned)` ,but `%0` is defined as different types in both modules ?

This is indeed a good suggestion. I am adding a link test (and it does bring up a case that I did not foresee, so I am also fixing it).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91250/new/

https://reviews.llvm.org/D91250



More information about the llvm-commits mailing list