[PATCH] D91693: [Support] Add reserve() method to the raw_ostream.

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 04:09:26 PST 2020


labath added reviewers: dblaikie, MaskRay.
labath added a comment.

I second the separate class idea. It seems like it could be much cleaner. The normal treatment of `reserve`-like methods is that of a hint -- one that the implementation could ignore or adjust in some circumstances -- I wouldn't expect that calling this method would completely change the way in which a file is accessed, nor that writing "beyond" the reserved storage would result in an assertion...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91693/new/

https://reviews.llvm.org/D91693



More information about the llvm-commits mailing list