[PATCH] D90175: [AArch64] Support conversion between fp16 and fp128

Adhemerval Zanella via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 03:59:35 PST 2020


zatrazz added a comment.

In D90175#2401747 <https://reviews.llvm.org/D90175#2401747>, @MaskRay wrote:

> Apologies for my slow response.
>
> Patches need to have a large context (see  https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface I prefer `arc diff`)

I keep forgetting this.

> The code generation part and the compiler-rt/lib/builtins part are logically independent and thus splitting the patch makes sense. The compiler-rt parts reasonable.

Ok, I will split it.

> Adding folks with better AArch64 knowledge...

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90175/new/

https://reviews.llvm.org/D90175



More information about the llvm-commits mailing list