[PATCH] D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 03:30:25 PST 2020


rengolin added a comment.

In D88389#2401213 <https://reviews.llvm.org/D88389#2401213>, @myhsu wrote:

> Oh, from the discussion on mailing list I thought this is a requirement.

And I'm possibly the one who told you this, and it's still valid. I was just expressing doubt over what back-ends have really done in the past (ie. I didn't try to build each patch in the series alone to verify and it's really hard to keep track of these things).

None of the other back-ends had to create the file like you do, so there's probably something that can be done instead. Check initial commits from other back-ends, like C-SKY, RISC-V, to see what they've done.

Perhaps it's as simple as splitting the series slightly differently, or avoid declaring too much on the initial patches and moving them down to the patches that actually define them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88389/new/

https://reviews.llvm.org/D88389



More information about the llvm-commits mailing list