[PATCH] D91324: [NewPM] Disable PreserveCFGChecker and add regression unit tests

Wed Nov 18 02:30:13 PST 2020

yrouban added a comment.

In D91324#2402069 <https://reviews.llvm.org/D91324#2402069>, @awarzynski wrote:

> Hi @yrouban, thank you for working on this! Unfortunately this breaks shared library builds (i.e. with `BUILD_SHARED_LIBS` set to ON). This is causing one of our buildbots to fail:
>
> - http://lab.llvm.org:8011/#/builders/66/builds/555
>
> Admittedly, it's been failing in the past 24hrs for other reasons too :)
>
> As the fix seemed trivial, I took the liberty of submitting a fixing patch without a review: https://github.com/llvm/llvm-project/commit/ccf500ce00c5768ae98248a8de90408488235aa7. Tested with `BUILD_SHARED_LIBS` and it builds fine. But I'm not that familiar with this codebase, so please comment/revert/update if I missed sth. Ta!

Thanks. I believe you did all right. There  were several unresolved symbols from SimplifyCFG reported as needed by PassManagerTest.cpp.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91324/new/

https://reviews.llvm.org/D91324