[PATCH] D91595: [Debugify] Support checking Machine IR debug info

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:316
 
+  /// Add a pass to check debug info for MIR.
+  void addCheckDebugPass();
----------------
please add `synthesized debug info`, since this checks the debugging info from debugify only (for now)


================
Comment at: llvm/lib/CodeGen/CMakeLists.txt:77
   MachineCSE.cpp
+  MachineCheckDebug.cpp
   MachineDebugify.cpp
----------------
I would pick `MachineCheckDebugify`, wdyt?


================
Comment at: llvm/lib/CodeGen/MachineCheckDebug.cpp:58
+        for (MachineInstr &MI : MBB) {
+          if (!MI.isDebugValue())
+            continue;
----------------
I think we should do this for finding missing variables; but for the checking of missing lines we should check more machine instructions (especially the instrs other than debug ones), right? Any reason we shouldn't do that?

Please check the `checkDebugifyMetadata()` (from Debugify.cpp) how it was done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91595/new/

https://reviews.llvm.org/D91595