[PATCH] D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 01:19:54 PST 2020


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/tests/CMakeLists.txt:43
+if(COMPILER_RT_TEST_COMPILER_ID MATCHES "Clang" AND NOT COMPILER_RT_DEBUG)
   list(APPEND ASAN_UNITTEST_COMMON_CFLAGS -gline-tables-only)
+elseif(COMPILER_RT_DEBUG)
----------------
why do we need this after list(APPEND COMPILER_RT_TEST_COMPILER_CFLAGS -gline-tables-only) above


================
Comment at: compiler-rt/lib/sanitizer_common/tests/sanitizer_stacktrace_test.cpp:71
 
+void BufferedStackTrace::UnwindImpl(uptr, uptr, void *, bool, u32) {
+}
----------------
why it's here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91620/new/

https://reviews.llvm.org/D91620



More information about the llvm-commits mailing list