[PATCH] D91533: [lib/Object] - Generalize the RelocationResolver API.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 01:19:33 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

All looks good to me, but probably want @MaskRay's input too.



================
Comment at: llvm/lib/Object/RelocationResolver.cpp:270
+static uint64_t resolveX86(uint64_t Type, uint64_t Offset, uint64_t S,
+                           uint64_t LocData, int64_t Addend) {
+  switch (Type) {
----------------
In all these functions, it might be clearer if you commented out/deleted the name of the unused parameters.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91533/new/

https://reviews.llvm.org/D91533



More information about the llvm-commits mailing list