[PATCH] D91677: Avoid transforming fortified bcopy to memmove

[Siddhesh Poyarekar via Phabricator via llvm-commits]

siddhesh added a comment.

In D91677#2401770 <https://reviews.llvm.org/D91677#2401770>, @serge-sans-paille wrote:

> The problem you're trying to solve doesn't seem specific to `bcopy`: any function with an inline definition should probably *not* be replaced, and the inlined definition should be favored. This was the spirit of that patch https://reviews.llvm.org/D71082. i wonder why your test case doesn't fall into that configuration.

Maybe because that D71082 <https://reviews.llvm.org/D71082> is limited to clang?  The bcopy survives clang but llvm forces it into a memmove without this patch.  Would you like to see this change be more generic, i.e. for any libcall, if the callee has a function body that has a call instruction in its first BB, avoid optimizing it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91677/new/

https://reviews.llvm.org/D91677