[PATCH] D90175: [AArch64] Support conversion between fp16 and fp128

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Apologies for my slow response.

Patches need to have a large context (see  https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface I prefer `arc diff`)
The code generation part and the compiler-rt/lib/builtins part are logically independent and thus splitting the patch makes sense. The compiler-rt parts reasonable.



================
Comment at: llvm/test/CodeGen/AArch64/arm64-fp128.ll:234
+; CHECK: ldr q0, [{{x[0-9]+}}, :lo12:lhs]
+; CHECK: bl __trunctfhf2
+; CHECK: str h0, [{{x[0-9]+}}, :lo12:varhalf]
----------------
Add `-NEXT` whenever appropriate


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90175/new/

https://reviews.llvm.org/D90175