[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

[LiuChen via Phabricator via llvm-commits]

LiuChen3 marked an inline comment as done.
LiuChen3 added a comment.

> 2. Delete IsPrefix parameter, and delete 'break'

It should be 'continue'. Sorry for this mistake.



================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3083
+      }
+      if (IsPrefix) {
+        NameLoc = Parser.getTok().getLoc();
----------------
pengfei wrote:
> You just need to check `ForcedVEXEncoding != VEXEncoding_Default`.
I think this is better. Multi vex/evex prefix doesn't make sense.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3084
+      if (IsPrefix) {
+        NameLoc = Parser.getTok().getLoc();
+        if (getLexer().isNot(AsmToken::Identifier))
----------------
pengfei wrote:
> Unused assignment. It may suppose to be used on line 3086.
This would be used later. However, this should only be updated when there is prefix. I put it in wrong place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90441/new/

https://reviews.llvm.org/D90441