[PATCH] D61767: [llvm-elfabi] Emit ELF header and string table section

Tue Nov 17 20:39:31 PST 2020

haowei added inline comments.

================
Comment at: llvm/test/tools/llvm-elfabi/fail-file-write.test:16
+
+# ERR: Permission denied when trying to open
----------------
jhenderson wrote:
> haowei wrote:
> > jhenderson wrote:
> > > jhenderson wrote:
> > > > Please check the full error here, rather than a partial one. Additionally, I would be suspicious that the error message will be different depending on whether the host OS is Linux or Windows. Please could you check? If you don't have access to both systems, let me know, and I can test the one you can't.
> > > Looking at the pre-merge checks this test is failing on Windows as-is.
> > I have a windows workstation but it does not have development environment set up for llvm. I will see if I can set it up tomorrow. For now, let me test it on bots first.
> Did you get anywhere with resolving this? The test is still failing on the pre-merge bot, as noted near the top of this page.
I finally get my windows workstation to build llvm successfully. So the reason this test failed on Windows is that, the `chmod` seems to be a no-op on windows. It didn't change the permission of the %t.TestDir at all. The failure at `not llvm-elfabi...` did not happen so the test failed.

I don't have a good workaround for this so I disabled the test under Windows for now. Do you have any good suggestion for testing this failure under Windows?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61767/new/

https://reviews.llvm.org/D61767