[PATCH] D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes
    Max Kazantsev via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Nov 17 20:37:00 PST 2020
    
    
  
mkazantsev added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2869
           RecursivelyDeleteTriviallyDeadInstructions(Inst, TLI, MSSAU.get());
+  }
 
----------------
Do I understand correctly that if `RecursivelyDeleteTriviallyDeadInstructions` is given a Phi as argument, it doesn't work with it correctly? Maybe we should do this inside of this function? Its name suggests that it should handle any instructions.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91153/new/
https://reviews.llvm.org/D91153
    
    
More information about the llvm-commits
mailing list