[PATCH] D91467: ADT: Take small enough, trivially copyable T by value in SmallVector (otherwise, assert)

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 18:25:11 PST 2020


dexonsmith added a comment.

In D91467#2401127 <https://reviews.llvm.org/D91467#2401127>, @silvas wrote:

> I think we can probably get a good signal from:
>
> 1. Clang execution time compiling some cpp file at by-value thresholds of `0`, `1 * sizeof(void*)`, `2 * sizeof(void*)` would be enough to get a signal on whether this is measurable performance wise.
> 2. Clang binary size for those 3 cases.

That sounds good. I'll throw in a version with no threshold.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91467/new/

https://reviews.llvm.org/D91467



More information about the llvm-commits mailing list