[PATCH] D89723: [CSSPGO][llvm-profgen]Context-sensitive profile data generation

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:486
+    FunctionSamples::ProfileIsCS = true;
+    PerfType = PERF_LBR_STACK;
   }
----------------
`PerfType` should be defined on the `else` branch if it is not initialized anywhere else. 


================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:265
+  static bool isHybridPerfScript(StringRef FileName) {
+    auto BufOrError = MemoryBuffer::getFileOrSTDIN(FileName, 4000);
+    if (!BufOrError)
----------------
Should this be rewritten with a stream-based file reader as done in D89707?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89723/new/

https://reviews.llvm.org/D89723