[PATCH] D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 16:21:00 PST 2020


clementval added a comment.

@Meinersbur Thanks for the review. Just updated the patch.



================
Comment at: llvm/unittests/Frontend/OpenACCTest.cpp:66-71
+class OpenACCTest : public testing::Test {
+protected:
+  void SetUp() override {}
+
+  void TearDown() override {}
+};
----------------
Meinersbur wrote:
> This fixup doesn't do anything, you can just used the non-fixup versions ('TEST(..)' instead of `TEST_F`)
Thanks for the tip. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91653/new/

https://reviews.llvm.org/D91653



More information about the llvm-commits mailing list