[PATCH] D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetInstrInfo.h:947
+  /// @return Whether this operand is allowed to be pc-relative.
+  virtual bool isRegisterOperandPCRel(const MachineOperand &MO) const {
+    return false;
----------------
rengolin wrote:
> Shouldn't you also have added the derived implementations for each target?
I'm not sure, is there a policy to enforce this? Because there is a default implementation here (i.e. `return false`) so functionally it works. Also some of the functions, the `isCopyInstrImpl` below for example, don't have implementations in every derived targets either


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88386/new/

https://reviews.llvm.org/D88386