[PATCH] D91460: [AsmParser] make .ascii/.asciz/.string support multiple strings

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 16:12:30 PST 2020


jcai19 added a comment.

> I think rejecting `.asciz "a" "b"` may be fine for us since there is no real world usage.
>
> Then I am not sure we need a new method `parseManyWithOptionalComma`. It can be specialized.

Does that mean we support space as separators in .ascii but not for .asciz and .string? Wouldn't that create more confusion?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91460/new/

https://reviews.llvm.org/D91460



More information about the llvm-commits mailing list