[PATCH] D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools

Wei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 17 14:35:35 PST 2020


weiwang added inline comments.


================
Comment at: lld/ELF/Options.td:546
+  "Minimum profile count required for an optimization remark to be output">,
+  MetaVarName<"<number>">;
 def opt_remarks_passes: Separate<["--"], "opt-remarks-passes">,
----------------
MaskRay wrote:
> MaskRay wrote:
> > `<integer>` might be preciser.
> This is not done
Since the value can be integer or 'auto', maybe <value> is more appropriate here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809



More information about the llvm-commits mailing list